#
cargo/util/toml_mut/
manifest.rs

    1
    2
    3
    4
    5
    6
    7
    8
    9
    10
    11
    12
    13
    14
    15
    16
    17
    18
    19
    20
    21
    22
    23
    24
    25
    26
    27
    28
    29
    30
    31
    32
    33
    34
    35
    36
    37
    38
    39
    40
    41
    42
    43
    44
    45
    46
    47
    48
    49
    50
    51
    52
    53
    54
    55
    56
    57
    58
    59
    60
    61
    62
    63
    64
    65
    66
    67
    68
    69
    70
    71
    72
    73
    74
    75
    76
    77
    78
    79
    80
    81
    82
    83
    84
    85
    86
    87
    88
    89
    90
    91
    92
    93
    94
    95
    96
    97
    98
    99
    100
    101
    102
    103
    104
    105
    106
    107
    108
    109
    110
    111
    112
    113
    114
    115
    116
    117
    118
    119
    120
    121
    122
    123
    124
    125
    126
    127
    128
    129
    130
    131
    132
    133
    134
    135
    136
    137
    138
    139
    140
    141
    142
    143
    144
    145
    146
    147
    148
    149
    150
    151
    152
    153
    154
    155
    156
    157
    158
    159
    160
    161
    162
    163
    164
    165
    166
    167
    168
    169
    170
    171
    172
    173
    174
    175
    176
    177
    178
    179
    180
    181
    182
    183
    184
    185
    186
    187
    188
    189
    190
    191
    192
    193
    194
    195
    196
    197
    198
    199
    200
    201
    202
    203
    204
    205
    206
    207
    208
    209
    210
    211
    212
    213
    214
    215
    216
    217
    218
    219
    220
    221
    222
    223
    224
    225
    226
    227
    228
    229
    230
    231
    232
    233
    234
    235
    236
    237
    238
    239
    240
    241
    242
    243
    244
    245
    246
    247
    248
    249
    250
    251
    252
    253
    254
    255
    256
    257
    258
    259
    260
    261
    262
    263
    264
    265
    266
    267
    268
    269
    270
    271
    272
    273
    274
    275
    276
    277
    278
    279
    280
    281
    282
    283
    284
    285
    286
    287
    288
    289
    290
    291
    292
    293
    294
    295
    296
    297
    298
    299
    300
    301
    302
    303
    304
    305
    306
    307
    308
    309
    310
    311
    312
    313
    314
    315
    316
    317
    318
    319
    320
    321
    322
    323
    324
    325
    326
    327
    328
    329
    330
    331
    332
    333
    334
    335
    336
    337
    338
    339
    340
    341
    342
    343
    344
    345
    346
    347
    348
    349
    350
    351
    352
    353
    354
    355
    356
    357
    358
    359
    360
    361
    362
    363
    364
    365
    366
    367
    368
    369
    370
    371
    372
    373
    374
    375
    376
    377
    378
    379
    380
    381
    382
    383
    384
    385
    386
    387
    388
    389
    390
    391
    392
    393
    394
    395
    396
    397
    398
    399
    400
    401
    402
    403
    404
    405
    406
    407
    408
    409
    410
    411
    412
    413
    414
    415
    416
    417
    418
    419
    420
    421
    422
    423
    424
    425
    426
    427
    428
    429
    430
    431
    432
    433
    434
    435
    436
    437
    438
    439
    440
    441
    442
    443
    444
    445
    446
    447
    448
    449
    450
    451
    452
    453
    454
    455
    456
    457
    458
    459
    460
    461
    462
    463
    464
    465
    466
    467
    468
    469
    470
    471
    472
    473
    474
    475
    476
    477
    478
    479
    480
    481
    482
    483
    484
    485
    486
    487
    488
    489
    490
    491
    492
    493
    494
    495
    496
    497
    498
    499
    500
    501
    502
    503
    504
    505
    506
    507
    508
    509
    510
    511
    512
    513
    514
    515
    516
    517
    518
    519
    520
    521
    522
    523
    524
    525
    526
    527
    528
    529
    530
    531
    532
    533
    534
    535
    536
    537
    538
    539
    540
    541
    542
    543
    544
    545
    546
    547
    548
    549
    550
    551
    552
    553
    554
    555
    556
    557
    558
    559
    560
    561
    562
    563
    564
    565
    566
    567
    568
    569
    570
    571
    572
    573
    574
    575
    576
    577
    578
    579
    580
    581
    582
    583
    584
    585
    586
    587
    588
    589
    590
    591
    592
    593
    594
    595
    596
    597
    598
    599
    600
    601
    602
    603
    604
    605
    606
    607
    608
    609
    610
    611
    612
    613
    614
    615
    616
    617
    618
    619
    620
    621
    622
    623
    624
    625
    626
    627
    628
    629
    630
    631
    632
    633
    634
    635
    636
    637
    638
    639
    640
    641
    642
    643
    644
    645
    646
    647
    648
    649
    650
    651
    652
    653
    654
    655
    656
    657
    658
    659
    660
    661
    662
    663
    664
    665
    666
    667
    668
    669
    670
    671
    672
    673
    674
    675
    676
    677
    678
    679
    680
    681
    682
    683
    684
    685
    686
    687
    688
    689
    690
    691
    692
    693
    694
    695
    696
    697
    698
    699
    700
    701
    702
    703
    704
    705
    706
    707
    708
    709
    710
    711
    712
    713
    714
    715
    716
    717
    718
    719
    720
    721
    722
    723
    724
    725
    726
    727
    728
    729
    730
    731
    732
    733
    734
    735
    736
    737
    738
    739
    740
    741
    742
    743
    744
    745
    746
    747
    748
    749
    750
    751
    752
    753
    754
    755

    //! Parsing and editing of manifest files.

    use std::ops::{Deref, DerefMut};
    use std::path::{Path, PathBuf};
    use std::str;

    use anyhow::Context as _;

    use super::dependency::Dependency;
    use crate::core::dependency::DepKind;
    use crate::core::{FeatureValue, Features, Workspace};
    use crate::util::closest;
    use crate::util::interning::InternedString;
    use crate::util::toml::{is_embedded, ScriptSource};
    use crate::{CargoResult, GlobalContext};

    /// Dependency table to add deps to.
    #[derive(Clone, Debug, PartialEq, Eq)]
    pub struct DepTable {
        kind: DepKind,
        target: Option<String>,
    }

    impl DepTable {
        const KINDS: &'static [Self] = &[
            Self::new().set_kind(DepKind::Normal),
            Self::new().set_kind(DepKind::Development),
            Self::new().set_kind(DepKind::Build),
        ];

        /// Reference to a Dependency Table.
        pub const fn new() -> Self {
            Self {
                kind: DepKind::Normal,
                target: None,
            }
        }

        /// Choose the type of dependency.
        pub const fn set_kind(mut self, kind: DepKind) -> Self {
            self.kind = kind;
            self
        }

        /// Choose the platform for the dependency.
        pub fn set_target(mut self, target: impl Into<String>) -> Self {
            self.target = Some(target.into());
            self
        }

        /// Type of dependency.
        pub fn kind(&self) -> DepKind {
            self.kind
        }

        /// Platform for the dependency.
        pub fn target(&self) -> Option<&str> {
            self.target.as_deref()
        }

        /// Keys to the table.
        pub fn to_table(&self) -> Vec<&str> {
            if let Some(target) = &self.target {
                vec!["target", target, self.kind.kind_table()]
            } else {
                vec![self.kind.kind_table()]
            }
        }
    }

    impl Default for DepTable {
        fn default() -> Self {
            Self::new()
        }
    }

    impl From<DepKind> for DepTable {
        fn from(other: DepKind) -> Self {
            Self::new().set_kind(other)
        }
    }

    /// An editable Cargo manifest.
    #[derive(Debug, Clone)]
    pub struct Manifest {
        /// Manifest contents as TOML data.
        pub data: toml_edit::DocumentMut,
    }

    impl Manifest {
        /// Get the manifest's package name.
        pub fn package_name(&self) -> CargoResult<&str> {
            self.data
                .as_table()
                .get("package")
                .and_then(|m| m.get("name"))
                .and_then(|m| m.as_str())
                .ok_or_else(parse_manifest_err)
        }

        /// Get the specified table from the manifest.
        pub fn get_table<'a>(&'a self, table_path: &[String]) -> CargoResult<&'a toml_edit::Item> {
            /// Descend into a manifest until the required table is found.
            fn descend<'a>(
                input: &'a toml_edit::Item,
                path: &[String],
            ) -> CargoResult<&'a toml_edit::Item> {
                if let Some(segment) = path.get(0) {
                    let value = input
                        .get(&segment)
                        .ok_or_else(|| non_existent_table_err(segment))?;

                    if value.is_table_like() {
                        descend(value, &path[1..])
                    } else {
                        Err(non_existent_table_err(segment))
                    }
                } else {
                    Ok(input)
                }
            }

            descend(self.data.as_item(), table_path)
        }

        /// Get the specified table from the manifest.
        pub fn get_table_mut<'a>(
            &'a mut self,
            table_path: &[String],
        ) -> CargoResult<&'a mut toml_edit::Item> {
            /// Descend into a manifest until the required table is found.
            fn descend<'a>(
                input: &'a mut toml_edit::Item,
                path: &[String],
            ) -> CargoResult<&'a mut toml_edit::Item> {
                if let Some(segment) = path.get(0) {
                    let mut default_table = toml_edit::Table::new();
                    default_table.set_implicit(true);
                    let value = input[&segment].or_insert(toml_edit::Item::Table(default_table));

                    if value.is_table_like() {
                        descend(value, &path[1..])
                    } else {
                        Err(non_existent_table_err(segment))
                    }
                } else {
                    Ok(input)
                }
            }

            descend(self.data.as_item_mut(), table_path)
        }

        /// Get all sections in the manifest that exist and might contain
        /// dependencies. The returned items are always `Table` or
        /// `InlineTable`.
        pub fn get_sections(&self) -> Vec<(DepTable, toml_edit::Item)> {
            let mut sections = Vec::new();

            for table in DepTable::KINDS {
                let dependency_type = table.kind.kind_table();
                // Dependencies can be in the three standard sections...
                if self
                    .data
                    .get(dependency_type)
                    .map(|t| t.is_table_like())
                    .unwrap_or(false)
                {
                    sections.push((table.clone(), self.data[dependency_type].clone()))
                }

                // ... and in `target.<target>.(build-/dev-)dependencies`.
                let target_sections = self
                    .data
                    .as_table()
                    .get("target")
                    .and_then(toml_edit::Item::as_table_like)
                    .into_iter()
                    .flat_map(toml_edit::TableLike::iter)
                    .filter_map(|(target_name, target_table)| {
                        let dependency_table = target_table.get(dependency_type)?;
                        dependency_table.as_table_like().map(|_| {
                            (
                                table.clone().set_target(target_name),
                                dependency_table.clone(),
                            )
                        })
                    });

                sections.extend(target_sections);
            }

            sections
        }

        pub fn get_legacy_sections(&self) -> Vec<String> {
            let mut result = Vec::new();

            for dependency_type in ["dev_dependencies", "build_dependencies"] {
                if self.data.contains_key(dependency_type) {
                    result.push(dependency_type.to_owned());
                }

                // ... and in `target.<target>.(build-/dev-)dependencies`.
                result.extend(
                    self.data
                        .as_table()
                        .get("target")
                        .and_then(toml_edit::Item::as_table_like)
                        .into_iter()
                        .flat_map(toml_edit::TableLike::iter)
                        .filter_map(|(target_name, target_table)| {
                            if target_table.as_table_like()?.contains_key(dependency_type) {
                                Some(format!("target.{target_name}.{dependency_type}"))
                            } else {
                                None
                            }
                        }),
                );
            }
            result
        }
    }

    impl str::FromStr for Manifest {
        type Err = anyhow::Error;

        /// Read manifest data from string
        fn from_str(input: &str) -> ::std::result::Result<Self, Self::Err> {
            let d: toml_edit::DocumentMut = input.parse().context("Manifest not valid TOML")?;

            Ok(Manifest { data: d })
        }
    }

    impl std::fmt::Display for Manifest {
        fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
            self.data.fmt(f)
        }
    }

    /// An editable Cargo manifest that is available locally.
    #[derive(Debug, Clone)]
    pub struct LocalManifest {
        /// Path to the manifest.
        pub path: PathBuf,
        /// Manifest contents.
        pub manifest: Manifest,
        /// The raw, unparsed package file
        pub raw: String,
        /// Edit location for an embedded manifest, if relevant
        pub embedded: Option<Embedded>,
    }

    impl Deref for LocalManifest {
        type Target = Manifest;

        fn deref(&self) -> &Manifest {
            &self.manifest
        }
    }

    impl DerefMut for LocalManifest {
        fn deref_mut(&mut self) -> &mut Manifest {
            &mut self.manifest
        }
    }

    impl LocalManifest {
        /// Construct the `LocalManifest` corresponding to the `Path` provided..
        pub fn try_new(path: &Path) -> CargoResult<Self> {
            if !path.is_absolute() {
                anyhow::bail!("can only edit absolute paths, got {}", path.display());
            }
            let raw = cargo_util::paths::read(&path)?;
            let mut data = raw.clone();
            let mut embedded = None;
            if is_embedded(path) {
                let source = ScriptSource::parse(&data)?;
                if let Some(frontmatter) = source.frontmatter() {
                    embedded = Some(Embedded::exists(&data, frontmatter));
                    data = frontmatter.to_owned();
                } else if let Some(shebang) = source.shebang() {
                    embedded = Some(Embedded::after(&data, shebang));
                    data = String::new();
                } else {
                    embedded = Some(Embedded::start());
                    data = String::new();
                }
            }
            let manifest = data.parse().context("Unable to parse Cargo.toml")?;
            Ok(LocalManifest {
                manifest,
                path: path.to_owned(),
                raw,
                embedded,
            })
        }

        /// Write changes back to the file.
        pub fn write(&self) -> CargoResult<()> {
            let mut manifest = self.manifest.data.to_string();
            let raw = match self.embedded.as_ref() {
                Some(Embedded::Implicit(start)) => {
                    if !manifest.ends_with("\n") {
                        manifest.push_str("\n");
                    }
                    let fence = "---\n";
                    let prefix = &self.raw[0..*start];
                    let suffix = &self.raw[*start..];
                    let empty_line = if prefix.is_empty() { "\n" } else { "" };
                    format!("{prefix}{fence}{manifest}{fence}{empty_line}{suffix}")
                }
                Some(Embedded::Explicit(span)) => {
                    if !manifest.ends_with("\n") {
                        manifest.push_str("\n");
                    }
                    let prefix = &self.raw[0..span.start];
                    let suffix = &self.raw[span.end..];
                    format!("{prefix}{manifest}{suffix}")
                }
                None => manifest,
            };
            let new_contents_bytes = raw.as_bytes();

            cargo_util::paths::write_atomic(&self.path, new_contents_bytes)
        }

        /// Lookup a dependency.
        pub fn get_dependency_versions<'s>(
            &'s self,
            dep_key: &'s str,
            ws: &'s Workspace<'_>,
            unstable_features: &'s Features,
        ) -> impl Iterator<Item = (DepTable, CargoResult<Dependency>)> + 's {
            let crate_root = self.path.parent().expect("manifest path is absolute");
            self.get_sections()
                .into_iter()
                .filter_map(move |(table_path, table)| {
                    let table = table.into_table().ok()?;
                    Some(
                        table
                            .into_iter()
                            .filter_map(|(key, item)| {
                                if key.as_str() == dep_key {
                                    Some((table_path.clone(), key, item))
                                } else {
                                    None
                                }
                            })
                            .collect::<Vec<_>>(),
                    )
                })
                .flatten()
                .map(move |(table_path, dep_key, dep_item)| {
                    let dep = Dependency::from_toml(
                        ws.gctx(),
                        ws.root(),
                        crate_root,
                        unstable_features,
                        &dep_key,
                        &dep_item,
                    );
                    (table_path, dep)
                })
        }

        /// Add entry to a Cargo.toml.
        pub fn insert_into_table(
            &mut self,
            table_path: &[String],
            dep: &Dependency,
            gctx: &GlobalContext,
            workspace_root: &Path,
            unstable_features: &Features,
        ) -> CargoResult<()> {
            let crate_root = self
                .path
                .parent()
                .expect("manifest path is absolute")
                .to_owned();
            let dep_key = dep.toml_key();

            let table = self.get_table_mut(table_path)?;
            if let Some((mut dep_key, dep_item)) = table
                .as_table_like_mut()
                .unwrap()
                .get_key_value_mut(dep_key)
            {
                dep.update_toml(
                    gctx,
                    workspace_root,
                    &crate_root,
                    unstable_features,
                    &mut dep_key,
                    dep_item,
                )?;
                if let Some(table) = dep_item.as_inline_table_mut() {
                    // So long as we don't have `Cargo.toml` auto-formatting and inline-tables can only
                    // be on one line, there isn't really much in the way of interesting formatting to
                    // include (no comments), so let's just wipe it clean
                    table.fmt();
                }
            } else {
                let new_dependency =
                    dep.to_toml(gctx, workspace_root, &crate_root, unstable_features)?;
                table[dep_key] = new_dependency;
            }

            Ok(())
        }

        /// Remove entry from a Cargo.toml.
        pub fn remove_from_table(&mut self, table_path: &[String], name: &str) -> CargoResult<()> {
            let parent_table = self.get_table_mut(table_path)?;

            match parent_table.get_mut(name).filter(|t| !t.is_none()) {
                Some(dep) => {
                    // remove the dependency
                    *dep = toml_edit::Item::None;

                    // remove table if empty
                    if parent_table.as_table_like().unwrap().is_empty() {
                        *parent_table = toml_edit::Item::None;
                    }
                }
                None => {
                    let names = parent_table
                        .as_table_like()
                        .map(|t| t.iter())
                        .into_iter()
                        .flatten();
                    let alt_name = closest(name, names.map(|(k, _)| k), |k| k).map(|n| n.to_owned());

                    // Search in other tables.
                    let sections = self.get_sections();
                    let found_table_path = sections.iter().find_map(|(t, i)| {
                        let table_path: Vec<String> =
                            t.to_table().iter().map(|s| s.to_string()).collect();
                        i.get(name).is_some().then(|| table_path.join("."))
                    });

                    return Err(non_existent_dependency_err(
                        name,
                        table_path.join("."),
                        found_table_path,
                        alt_name.as_deref(),
                    ));
                }
            }

            Ok(())
        }

        /// Allow mutating depedencies, wherever they live.
        /// Copied from cargo-edit.
        pub fn get_dependency_tables_mut(
            &mut self,
        ) -> impl Iterator<Item = &mut dyn toml_edit::TableLike> + '_ {
            let root = self.data.as_table_mut();
            root.iter_mut().flat_map(|(k, v)| {
                if DepTable::KINDS
                    .iter()
                    .any(|dt| dt.kind.kind_table() == k.get())
                {
                    v.as_table_like_mut().into_iter().collect::<Vec<_>>()
                } else if k == "workspace" {
                    v.as_table_like_mut()
                        .unwrap()
                        .iter_mut()
                        .filter_map(|(k, v)| {
                            if k.get() == "dependencies" {
                                v.as_table_like_mut()
                            } else {
                                None
                            }
                        })
                        .collect::<Vec<_>>()
                } else if k == "target" {
                    v.as_table_like_mut()
                        .unwrap()
                        .iter_mut()
                        .flat_map(|(_, v)| {
                            v.as_table_like_mut().into_iter().flat_map(|v| {
                                v.iter_mut().filter_map(|(k, v)| {
                                    if DepTable::KINDS
                                        .iter()
                                        .any(|dt| dt.kind.kind_table() == k.get())
                                    {
                                        v.as_table_like_mut()
                                    } else {
                                        None
                                    }
                                })
                            })
                        })
                        .collect::<Vec<_>>()
                } else {
                    Vec::new()
                }
            })
        }

        /// Remove references to `dep_key` if its no longer present.
        pub fn gc_dep(&mut self, dep_key: &str) {
            let explicit_dep_activation = self.is_explicit_dep_activation(dep_key);
            let status = self.dep_status(dep_key);

            if let Some(toml_edit::Item::Table(feature_table)) =
                self.data.as_table_mut().get_mut("features")
            {
                for (_feature, mut feature_values) in feature_table.iter_mut() {
                    if let toml_edit::Item::Value(toml_edit::Value::Array(feature_values)) =
                        &mut feature_values
                    {
                        fix_feature_activations(
                            feature_values,
                            dep_key,
                            status,
                            explicit_dep_activation,
                        );
                    }
                }
            }
        }

        pub fn is_explicit_dep_activation(&self, dep_key: &str) -> bool {
            if let Some(toml_edit::Item::Table(feature_table)) = self.data.as_table().get("features") {
                for values in feature_table
                    .iter()
                    .map(|(_, a)| a)
                    .filter_map(|i| i.as_value())
                    .filter_map(|v| v.as_array())
                {
                    for value in values.iter().filter_map(|v| v.as_str()) {
                        let value = FeatureValue::new(InternedString::new(value));
                        if let FeatureValue::Dep { dep_name } = &value {
                            if dep_name.as_str() == dep_key {
                                return true;
                            }
                        }
                    }
                }
            }

            false
        }

        fn dep_status(&self, dep_key: &str) -> DependencyStatus {
            let mut status = DependencyStatus::None;
            for (_, tbl) in self.get_sections() {
                if let toml_edit::Item::Table(tbl) = tbl {
                    if let Some(dep_item) = tbl.get(dep_key) {
                        let optional = dep_item
                            .get("optional")
                            .and_then(|i| i.as_value())
                            .and_then(|i| i.as_bool())
                            .unwrap_or(false);
                        if optional {
                            return DependencyStatus::Optional;
                        } else {
                            status = DependencyStatus::Required;
                        }
                    }
                }
            }
            status
        }
    }

    impl std::fmt::Display for LocalManifest {
        fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
            self.manifest.fmt(f)
        }
    }

    /// Edit location for an embedded manifest
    #[derive(Clone, Debug)]
    pub enum Embedded {
        /// Manifest is implicit
        ///
        /// This is the insert location for a frontmatter
        Implicit(usize),
        /// Manifest is explicit in a frontmatter
        ///
        /// This is the span of the frontmatter body
        Explicit(std::ops::Range<usize>),
    }

    impl Embedded {
        fn start() -> Self {
            Self::Implicit(0)
        }

        fn after(input: &str, after: &str) -> Self {
            let span = substr_span(input, after);
            let end = span.end;
            Self::Implicit(end)
        }

        fn exists(input: &str, exists: &str) -> Self {
            let span = substr_span(input, exists);
            Self::Explicit(span)
        }
    }

    fn substr_span(haystack: &str, needle: &str) -> std::ops::Range<usize> {
        let haystack_start_ptr = haystack.as_ptr();
        let haystack_end_ptr = haystack[haystack.len()..haystack.len()].as_ptr();

        let needle_start_ptr = needle.as_ptr();
        let needle_end_ptr = needle[needle.len()..needle.len()].as_ptr();

        assert!(needle_end_ptr < haystack_end_ptr);
        assert!(haystack_start_ptr <= needle_start_ptr);
        let start = needle_start_ptr as usize - haystack_start_ptr as usize;
        let end = start + needle.len();

        start..end
    }

    #[derive(Copy, Clone, PartialEq, Eq, PartialOrd, Ord)]
    enum DependencyStatus {
        None,
        Optional,
        Required,
    }

    fn fix_feature_activations(
        feature_values: &mut toml_edit::Array,
        dep_key: &str,
        status: DependencyStatus,
        explicit_dep_activation: bool,
    ) {
        let remove_list: Vec<usize> = feature_values
            .iter()
            .enumerate()
            .filter_map(|(idx, value)| value.as_str().map(|s| (idx, s)))
            .filter_map(|(idx, value)| {
                let parsed_value = FeatureValue::new(InternedString::new(value));
                match status {
                    DependencyStatus::None => match (parsed_value, explicit_dep_activation) {
                        (FeatureValue::Feature(dep_name), false)
                        | (FeatureValue::Dep { dep_name }, _)
                        | (FeatureValue::DepFeature { dep_name, .. }, _) => dep_name == dep_key,
                        _ => false,
                    },
                    DependencyStatus::Optional => false,
                    DependencyStatus::Required => match (parsed_value, explicit_dep_activation) {
                        (FeatureValue::Feature(dep_name), false)
                        | (FeatureValue::Dep { dep_name }, _) => dep_name == dep_key,
                        (FeatureValue::Feature(_), true) | (FeatureValue::DepFeature { .. }, _) => {
                            false
                        }
                    },
                }
                .then(|| idx)
            })
            .collect();

        // Remove found idx in revers order so we don't invalidate the idx.
        for idx in remove_list.iter().rev() {
            remove_array_index(feature_values, *idx);
        }

        if status == DependencyStatus::Required {
            for value in feature_values.iter_mut() {
                let parsed_value = if let Some(value) = value.as_str() {
                    FeatureValue::new(InternedString::new(value))
                } else {
                    continue;
                };
                if let FeatureValue::DepFeature {
                    dep_name,
                    dep_feature,
                    weak,
                } = parsed_value
                {
                    if dep_name == dep_key && weak {
                        let mut new_value = toml_edit::Value::from(format!("{dep_name}/{dep_feature}"));
                        *new_value.decor_mut() = value.decor().clone();
                        *value = new_value;
                    }
                }
            }
        }
    }

    pub fn str_or_1_len_table(item: &toml_edit::Item) -> bool {
        item.is_str() || item.as_table_like().map(|t| t.len() == 1).unwrap_or(false)
    }

    fn parse_manifest_err() -> anyhow::Error {
        anyhow::format_err!("unable to parse external Cargo.toml")
    }

    fn non_existent_table_err(table: impl std::fmt::Display) -> anyhow::Error {
        anyhow::format_err!("the table `{table}` could not be found.")
    }

    fn non_existent_dependency_err(
        name: impl std::fmt::Display,
        search_table: impl std::fmt::Display,
        found_table: Option<impl std::fmt::Display>,
        alt_name: Option<&str>,
    ) -> anyhow::Error {
        let mut msg = format!("the dependency `{name}` could not be found in `{search_table}`");
        if let Some(found_table) = found_table {
            msg.push_str(&format!("; it is present in `{found_table}`",));
        } else if let Some(alt_name) = alt_name {
            msg.push_str(&format!("; dependency `{alt_name}` exists",));
        }
        anyhow::format_err!(msg)
    }

    fn remove_array_index(array: &mut toml_edit::Array, index: usize) {
        let value = array.remove(index);

        // Captures all lines before leading whitespace
        let prefix_lines = value
            .decor()
            .prefix()
            .and_then(|p| p.as_str().expect("spans removed").rsplit_once('\n'))
            .map(|(lines, _current)| lines);
        // Captures all lines after trailing whitespace, before the next comma
        let suffix_lines = value
            .decor()
            .suffix()
            .and_then(|p| p.as_str().expect("spans removed").split_once('\n'))
            .map(|(_current, lines)| lines);
        let mut merged_lines = String::new();
        if let Some(prefix_lines) = prefix_lines {
            merged_lines.push_str(prefix_lines);
            merged_lines.push('\n');
        }
        if let Some(suffix_lines) = suffix_lines {
            merged_lines.push_str(suffix_lines);
            merged_lines.push('\n');
        }

        let next_index = index; // Since `index` was removed, that effectively auto-advances us
        if let Some(next) = array.get_mut(next_index) {
            let next_decor = next.decor_mut();
            let next_prefix = next_decor
                .prefix()
                .map(|s| s.as_str().expect("spans removed"))
                .unwrap_or_default();
            merged_lines.push_str(next_prefix);
            next_decor.set_prefix(merged_lines);
        } else {
            let trailing = array.trailing().as_str().expect("spans removed");
            merged_lines.push_str(trailing);
            array.set_trailing(merged_lines);
        }
    }