# Development Guide

Some general guidelines regarding development in pytest for maintainers and contributors. Nothing here is set in stone and can't be changed, feel free to suggest improvements or changes in the workflow.

## Code Style

- PEP-8
- flake8 for quality checks
- invoke to automate development tasks

## Branches

We have two long term branches:

- `master`: contains the code for the next bugfix release.
- `features`: contains the code with new features for the next minor release.

The official repository usually does not contain topic branches, developers and contributors should create topic branches in their own forks.

Exceptions can be made for cases where more than one contributor is working on the same topic or where it makes sense to use some automatic capability of the main repository, such as automatic docs from readthedocs for a branch dealing with documentation refactoring.

## Issues

Any question, feature, bug or proposal is welcome as an issue. Users are encouraged to use them whenever they need.

GitHub issues should use labels to categorize them. Labels should be created sporadically, to fill a niche; we should avoid creating labels just for the sake of creating them.

Each label should include a description in the GitHub's interface stating its purpose.

Labels are managed using labels. All the labels in the repository are kept in `.github/labels.toml`, so any changes should be via PRs to that file. After a PR is accepted and merged, one of the maintainers must manually synchronize the labels file with the GitHub repository.

### Temporary labels

To classify issues for a special event it is encouraged to create a temporary label. This helps those involved to find the relevant issues to work on. Examples of that are sprints in Python events or global hacking events.

- `temporary: EP2017 sprint`: candidate issues or PRs tackled during the EuroPython 2017

Issues created at those events should have other relevant labels added as well.

Those labels should be removed after they are no longer relevant.

## Release Procedure

Our current policy for releasing is to aim for a bugfix every few weeks and a minor release every 2-3 months. The idea is to get fixes and new features out instead of trying to cram a ton of features into a release and by consequence taking a lot of time to make a new one.

Important

pytest releases must be prepared on Linux because the docs and examples expect to be executed in that platform.

1. Create a branch `release-X.Y.Z` with the version for the release.

   - patch releases: from the latest `master`;
   - minor releases: from the latest `features`; then merge with the latest `master`;

   Ensure your are in a clean work tree.

2. Using `tox`, generate docs, changelog, announcements:

       $ tox -e release -- <VERSION>

   This will generate a commit with all the changes ready for pushing.

3. Open a PR for this branch targeting `master`.

4. After all tests pass and the PR has been approved, publish to PyPI by pushing the tag:

       git tag <VERSION>
       git push git@github.com:pytest-dev/pytest.git <VERSION>

   Wait for the deploy to complete, then make sure it is available on PyPI.

5. Merge the PR into `master`.

6. Send an email announcement with the contents from:

       doc/en/announce/release-<VERSION>.rst

   To the following mailing lists:

   - pytest-dev@python.org (all releases)
   - python-announce-list@python.org (all releases)
   - testing-in-python@lists.idyll.org (only major/minor releases)

   And announce it on Twitter with the `#pytest` hashtag.